openssl / openssl

TLS/SSL and crypto library
https://www.openssl.org
Apache License 2.0
25.4k stars 10.05k forks source link

Use BoringSSL/LibreSSL’s CBB and CBS #19564

Open DemiMarie opened 1 year ago

DemiMarie commented 1 year ago

BoringSSL and LibreSSL have CBB and CBS structures that avoid buffer overflows. OpenSSL should use something similar for all internal buffer management.

t8m commented 1 year ago

We have WPACKET which is basically that. We just need to use it where appropriate.

DemiMarie commented 1 year ago

We have WPACKET which is basically that. We just need to use it where appropriate.

I consider all parsing of untrusted data to be appropriate uses. In particular, this includes the ASN.1 encoder and decoder.

DemiMarie commented 1 year ago

And the punycode implementation.

nhorman commented 3 months ago

marking as inactive, will be closed at the completion of 3.4 dev without further input