search

openssl / project

Tracking of project related issues
2 stars 1 forks source link

feature branch: feature/acert-cli #845

Closed JonathanWilbur closed 2 weeks ago

JonathanWilbur commented 2 months ago

Feature Branch Name: feature/acert-cli Estimated Time to Completion: End of year 2024 (The code was already written; it just needs review)

There is currently no issue for this, but I can create one if requested. This feature-branch was requested by OpenSSL maintainers as a result of this PR: https://github.com/openssl/openssl/pull/25441.

I will re-iterate my opinion that we should not actually create a feature-branch for this, which I stated here:

Actually, I take that back. I know I am outnumbered here, but I don't think this should be in a feature branch at all. This PR (which is not really that big overall), can be split into several smaller PRs already, each of which are individually useful, and they could be merged in any any order. I could create a PR for a CLI that supports no signing and verification and only printing, or I could create a PR that supports signing and verifying attribute certificates with no CLI, and even these can be broken down further into useful atoms.

The overhead of repeatedly having to rebase and the possibility of these changes not making it into 3.5.0 because they are collectively only 90% done does not sound worth it to me.

But that is just a point made about the technical usefulness of a feature branch. If you still want a feature branch as an administrative formality, I will still do whatever you want.

JonathanWilbur commented 1 month ago

@t-j-h Hello, I believe I am blocked on doing this work on there being a feature branch. Can one be created for this?

t8m commented 1 month ago

+1 to create the branch.

t8m commented 1 month ago

@t-j-h could you please ack it formally here?

JonathanWilbur commented 1 month ago

Hello @t-j-h sorry to bother you, but I figured I would bump, since 3.4.0 is released now, and I figured you might have been busy with that.

arapov commented 2 weeks ago

ACK for the feature branch.

t8m commented 2 weeks ago

feature/acert-cli branch was created.