search

openssl / technical-policies

Mirror of the repository for technical policies, governed by the OTC (OpenSSL Technical Committee)
20 stars 32 forks source link

coding-style.md: add various rules on names #48

Closed DDvO closed 2 years ago

DDvO commented 2 years ago

Add a 3rd chunk of rules, taken from the list of proposed ones collected at https://github.com/openssl/openssl/issues/10725, focusing on names.

On this occasion clean up redundancy in the Naming chapter and re-order the rules.

DDvO commented 2 years ago

@levitte are your above points sufficiently addressed, so can you approve?

t8m commented 2 years ago

@DDvO Would you like to address (at least some) @slontis comments?

DDvO commented 2 years ago

@DDvO Would you like to address (at least some) @slontis comments?

Sure - I've just been too busy to get back to it, but done now.

t8m commented 2 years ago

Starting the vote for coding-style.md: add various rules on names at commit 5a3b1ac

t8m commented 2 years ago

Vote: [+1]

mattcaswell commented 2 years ago

Vote: [+1]

romen commented 2 years ago

Vote: [+0]

beldmit commented 2 years ago

Vote: [+1]

slontis commented 2 years ago

Vote: [+1]

t-j-h commented 2 years ago

Vote: [+1]

paulidale commented 2 years ago

Vote: [+1]

kroeckx commented 2 years ago

Voting +1

levitte commented 2 years ago

Vote: [+1]

t8m commented 2 years ago

@mspncp ping for vote

mspncp commented 2 years ago

Vote: [+1]

t8m commented 2 years ago

Closing the vote.

Topic: coding-style.md: add various rules on names at commit 5a3b1ac
       This will become an official OTC policy.
Proposed by: Tomas
Issue link: https://github.com/openssl/technical-policies/pull/48
Public: yes
Opened: 2022-05-25
Closed: 2022-06-02
Accepted: yes   (for: 9, against: 0, abstained: 1, not voted: 0)

   Dmitry     [+1]
   Matt       [+1]
   Pauli      [+1]
   Tim        [+1]
   Richard    [+1]
   Shane      [+1]
   Tomas      [+1]
   Kurt       [+1]
   Matthias   [+1]
   Nicola     [+0]