Closed hlandau closed 1 year ago
Updated.
It's been 18 days, so I'm now raising the vote on this. cc @openssl/otc
topic: Approve the proposed test labelling policy (technical-policies#57)
Proposed by Hugo Landau
Public: yes
opened: 2022-11-07
closed:
accepted: yes/no (for: X, against: Y, abstained: Z, not voted: T)
Dmitry [ ]
Matt [ ]
Pauli [ ]
Tim [ ]
Hugo [+1]
Richard [ ]
Shane [ ]
Tomas [ ]
Kurt [ ]
Matthias [ ]
Nicola [ ]
Vote: [+1]
Vote [0]
Vote: [+1]
Voting +1
Vote: [+1]
Vote +1
From: Pauli @.> Sent: Tuesday, November 8, 2022 7:21 AM To: openssl/technical-policies @.> Cc: Shane Lontis @.>; Comment @.> Subject: [External] : Re: [openssl/technical-policies] Revise testing policy with labels (PR #57)
Vote: [+1]
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/openssl/technical-policies/pull/57*issuecomment-1306209082__;Iw!!ACWV5N9M2RV99hQ!JZEsOB6_fFLxbduj79hUgn6xvEQpeLd9CKR7TSI9NOcaTCsjeAerbHftF6dsRyVbN2KIiElZko0ybfPodKsHAqgFBQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AJUSG6SEU35J2GIH7GI6K63WHFXE7ANCNFSM6AAAAAARKI3IBU__;!!ACWV5N9M2RV99hQ!JZEsOB6_fFLxbduj79hUgn6xvEQpeLd9CKR7TSI9NOcaTCsjeAerbHftF6dsRyVbN2KIiElZko0ybfPodKtlnDjDLw$. You are receiving this because you commented.Message ID: @.***>
Vote: [+1]
Vote: [+1]
(Side Note: @hlandau it would be nice if you could follow the current coloring practice for the labels, i.e., reuse the existing red color for the hold: tests needed
label (the hex value appears and can be copy&pasted when you 'edit' one of the existing labels) and choose a new, easily distinguishable color of your liking for the new tests: *
labels.)
(Side Note: @hlandau it would be nice if you could follow the current coloring practice for the labels, i.e., reuse the existing red color for the
hold: tests needed
label (the hex value appears and can be copy&pasted when you 'edit' one of the existing labels) and choose a new, easily distinguishable color of your liking for the newtests: *
labels.)
Agreed, this is my plan: red for the hold, something visually distinct for the other test labels.
Since the outcome of the vote is now a foregone conclusion, this vote can now be closed.
topic: Approve the proposed test labelling policy (technical-policies#57)
Proposed by Hugo Landau
Public: yes
opened: 2022-11-07
closed: 2022-11-10
accepted: yes (for: 8, against: 0, abstained: 1, not voted: 2)
Dmitry [+1]
Matt [+1]
Pauli [+1]
Tim [ 0]
Hugo [+1]
Richard [ ]
Shane [+1]
Tomas [+1]
Kurt [+1]
Matthias [+1]
Nicola [ ]
Vote: [+0]
I've immediately realized that we could avoid some labeling pollution by not requiring the test: exempted
label on PRs that are just triaged: documentation
or triaged: cleanup
or triaged: design
or maybe even triaged: refactor
.
First draft. Let me know your thoughts. I've tried to avoid overengineering this for now.