search

openstack-charmers / charm-interface-vault-kv

Vault interface for simple KV secrets management
Other
0 stars 6 forks source link

Support multiple remote bindings #5

Closed dosaboy closed 5 years ago

dosaboy commented 5 years ago

Also adds support for remote unit to provide unit_name explicitly so that roles are created correctly when using Juju cross-model relations.

Closes-Bug: #1826892

johnsca commented 5 years ago

I don't think this was correct. This, and the related Vault charm change, cause relations which don't happen to be associated with access or external to never get a URL. See https://bugs.launchpad.net/vault-charm/+bug/1843809

I think the more proper thing to do is for Vault's get_api_url to be called using Vault's ingress address for each relation on the endpoint. This way, it would work no matter what network the relation was made over (using juju add-relation --via), while still allowing the operator to specify that Vault should listen on a particular network for access and optionally external.