search

openstack-charmers / zaza-openstack-tests

OpenStack Charms Functional Test Library for Zaza
Apache License 2.0
7 stars 77 forks source link

Add integration test for Ceph RGW multisite sync policies feature #1193

Closed ionutbalutoiu closed 3 months ago

ionutbalutoiu commented 5 months ago

Add Ceph RGW multisite sync policies integration test.

Add integration test for the Multisite sync policies feature proposed to the upstream ceph-radosgw Juju charm:

ionutbalutoiu commented 5 months ago

/cc @UtkarshBhatthere

ionutbalutoiu commented 4 months ago

LGTM

I rebased this PR against latest upstream main branch.

I noticed that a new test case (test_005_virtual_hosted_bucket) was added after test_004_migration_and_multisite_failover.

Besides renaming test_004_migration_and_multisite_failover to test_100_migration_and_multisite_failover as discussed previously (to have the multi-site scaledown scenario run last), I also renamed test_005_virtual_hosted_bucket to test_101_virtual_hosted_bucket to keep the same test order.

See commit CephRGWTest: Reorder test cases from this PR.

Besides the tests re-order, I also updated the new test case test_004_multisite_directional_sync_policy with my findings regarding the CI failures with focal-yoga-multisite (which installs Ceph Quincy release). More details in this comment from charm-ceph-radosgw patchset.

ionutbalutoiu commented 4 months ago

LGTM

I rebased this PR against latest upstream main branch.

I noticed that a new test case (test_005_virtual_hosted_bucket) was added after test_004_migration_and_multisite_failover.

Besides renaming test_004_migration_and_multisite_failover to test_100_migration_and_multisite_failover as discussed previously (to have the multi-site scaledown scenario run last), I also renamed test_005_virtual_hosted_bucket to test_101_virtual_hosted_bucket to keep the same test order.

See commit CephRGWTest: Reorder test cases from this PR.

Besides the tests re-order, I also updated the new test case test_004_multisite_directional_sync_policy with my findings regarding the CI failures with focal-yoga-multisite (which installs Ceph Quincy release). More details in this comment from charm-ceph-radosgw patchset.

Also, I included a small fix that might cause failures sometimes (it happened on my local Zaza env).

sabaini commented 3 months ago

Thanks, lgtm! -- Merged