openstack-charmers / zaza-openstack-tests

OpenStack Charms Functional Test Library for Zaza
Apache License 2.0
7 stars 77 forks source link

Fixes endpoint discovery for RGW application under test #1217

Closed UtkarshBhatthere closed 3 months ago

UtkarshBhatthere commented 3 months ago

Charm-Ceph-RGW configures Apache for Admin/Public bindings. The original test queries the charm for the default public address (i.e. address on the "" binding) to perform object IO (S3) which fails because the endpoint is not correct. For IO test, we need to fetch the address bound to the PUBLIC juju space, this PR fetches the same with network-get and uses that to perform object IO instead.

UtkarshBhatthere commented 3 months ago

@sabaini

ubuntu@lab1-silo4-cpe-5501a315-0336-4dd7-a145-7133a8084963:~/.local/share/juju$ juju spaces
Name                Space ID  Subnets        
alpha               0                        
oam-space           1         10.X.246.164.0/22
public-space        2         10.X.246.172.0/22
internal-space      3         10.X.246.168.0/22
external-space      4         10.X.246.180.0/22
ceph-replica-space  5         10.X.246.176.0/22
undefined           6         10.Y.187.0/24

ubuntu@lab1-silo4-cpe-5501a315-0336-4dd7-a145-7133a8084963:~/.local/share/juju$ JUJU_DATA=/home/ubuntu/.local/share/juju/ fcbtest.zaza functest-test --model foundations-maas:ceph-standalone --tests zaza.openstack.charm_tests.ceph.tests.CephRGWTest
2024-06-14 14:48:58 [INFO] ## Running Test zaza.openstack.charm_tests.ceph.tests.CephRGWTest ##
2024-06-14 14:48:59 [WARNING] Unable to load charm config, deducing charm_name from cwd: "juju"
2024-06-14 14:49:00 [INFO] test_001_processes (zaza.openstack.charm_tests.ceph.tests.CephRGWTest)
2024-06-14 14:49:00 [INFO] Verify Ceph processes.
2024-06-14 14:49:00 [INFO]  ... 
2024-06-14 14:49:00 [INFO] Checking radosgw processes...
2024-06-14 14:49:11 [INFO] ok
2024-06-14 14:49:11 [INFO] test_002_services (zaza.openstack.charm_tests.ceph.tests.CephRGWTest)
2024-06-14 14:49:11 [INFO] Verify the ceph services.
2024-06-14 14:49:11 [INFO]  ... 
2024-06-14 14:49:11 [INFO] Checking radosgw services...
2024-06-14 14:49:14 [INFO] ok
2024-06-14 14:49:14 [INFO] test_003_object_storage_and_secondary_block (zaza.openstack.charm_tests.ceph.tests.CephRGWTest)
2024-06-14 14:49:14 [INFO] Verify Object Storage API and Secondary Migration block.
2024-06-14 14:49:14 [INFO]  ... 
2024-06-14 14:49:14 [INFO] Checking Object Storage API for Primary Cluster
2024-06-14 14:49:14 [INFO] Unit: ceph-radosgw/0, Endpoint: 10.X.246.173.3
2024-06-14 14:49:16 [INFO] Skipping Secondary Object gatewaty verification
2024-06-14 14:49:16 [INFO] ok
2024-06-14 14:49:16 [INFO] test_004_migration_and_multisite_failover (zaza.openstack.charm_tests.ceph.tests.CephRGWTest)
2024-06-14 14:49:16 [INFO] Perform multisite migration and verify failover.
2024-06-14 14:49:16 [INFO]  ... 
2024-06-14 14:49:16 [INFO] skipped 'Skipping Migration Test'
2024-06-14 14:49:16 [INFO] test_005_virtual_hosted_bucket (zaza.openstack.charm_tests.ceph.tests.CephRGWTest)
2024-06-14 14:49:16 [INFO] Test virtual hosted bucket.
2024-06-14 14:49:16 [INFO]  ... 
2024-06-14 14:49:16 [INFO] Skipping virtual hosted bucket test since primary rgw unit is not in active state
2024-06-14 14:49:16 [INFO] ok
2024-06-14 14:49:16 [INFO] ----------------------------------------------------------------------
2024-06-14 14:49:16 [INFO] Ran 5 tests in 17.072s
2024-06-14 14:49:16 [INFO] OK
2024-06-14 14:49:16 [INFO]  (skipped=1)
2024-06-14 14:49:16 [INFO] Events:
  Test zaza.openstack.charm_tests.ceph.tests.CephRGWTest:
    Start: 1718376538.627408
    Finish: 1718376556.7700348
    Elapsed Time: 18.142626762390137
    PCT Of Run Time: 100
Metadata: {}
ajkavanagh commented 3 months ago

@UtkarshBhatthere Please could you add some description into the PR about why this patch is needed; i.e does it fix a bug? Is it a regression being resolved? A workaround? i.e. we need something to explain why this should be included right up in the description of the PR. Thank.

UtkarshBhatthere commented 3 months ago

@ajkavanagh Thanks for the reminder, I have added a description for the change.