openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
11 stars 47 forks source link

Correct get_application_ip on k8s with missing app #578

Closed gnuoy closed 2 years ago

gnuoy commented 2 years ago

Fix get_application_ip so that it returns an empty string if the application is missing with the k8s provider. This makes it consistent with the non-k8s version.

codecov[bot] commented 2 years ago

Codecov Report

Base: 89.22% // Head: 89.22% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (6d5ee8c) compared to base (273b3b9). Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #578 +/- ## ========================================== - Coverage 89.22% 89.22% -0.01% ========================================== Files 44 44 Lines 4623 4629 +6 ========================================== + Hits 4125 4130 +5 - Misses 498 499 +1 ``` | [Impacted Files](https://codecov.io/gh/openstack-charmers/zaza/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers) | Coverage Δ | | |---|---|---| | [zaza/utilities/juju.py](https://codecov.io/gh/openstack-charmers/zaza/pull/578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers#diff-emF6YS91dGlsaXRpZXMvanVqdS5weQ==) | `92.48% <85.71%> (-0.33%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.