openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
11 stars 47 forks source link

Add support for ignore_hard_deploy_errors #581

Closed gnuoy closed 2 years ago

gnuoy commented 2 years ago

Add support for the ignore_hard_deploy_errors option. If this is set to true then charms going into an error state during deployment will not be fatal. This is useful with k8s charms which can transition into an error state if a container image takes time to download.

codecov[bot] commented 2 years ago

Codecov Report

Base: 89.22% // Head: 89.23% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (c2d2590) compared to base (1205fb3). Patch coverage: 96.42% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #581 +/- ## ========================================== + Coverage 89.22% 89.23% +0.01% ========================================== Files 44 44 Lines 4629 4644 +15 ========================================== + Hits 4130 4144 +14 - Misses 499 500 +1 ``` | [Impacted Files](https://codecov.io/gh/openstack-charmers/zaza/pull/581?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers) | Coverage Δ | | |---|---|---| | [zaza/charm\_lifecycle/deploy.py](https://codecov.io/gh/openstack-charmers/zaza/pull/581/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers#diff-emF6YS9jaGFybV9saWZlY3ljbGUvZGVwbG95LnB5) | `92.16% <ø> (ø)` | | | [zaza/model.py](https://codecov.io/gh/openstack-charmers/zaza/pull/581/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers#diff-emF6YS9tb2RlbC5weQ==) | `86.93% <94.73%> (-0.03%)` | :arrow_down: | | [zaza/charm\_lifecycle/func\_test\_runner.py](https://codecov.io/gh/openstack-charmers/zaza/pull/581/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers#diff-emF6YS9jaGFybV9saWZlY3ljbGUvZnVuY190ZXN0X3J1bm5lci5weQ==) | `73.56% <100.00%> (+0.30%)` | :arrow_up: | | [zaza/charm\_lifecycle/utils.py](https://codecov.io/gh/openstack-charmers/zaza/pull/581/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers#diff-emF6YS9jaGFybV9saWZlY3ljbGUvdXRpbHMucHk=) | `94.04% <100.00%> (+0.25%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.