Closed coreycb closed 1 year ago
I didn't think there would be a use case to use more than one PPA but it might not hurt to code it that way from the start. yeah, I'm thinking on the edge cases where you want to stack a ppa from your personal namespace with the security proposed ppa, because you are testing a bug or something.
Patch coverage: 100.00
% and project coverage change: +0.05
:tada:
Comparison is base (
b2f2b46
) 89.17% compared to head (986474b
) 89.22%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The current py36 failures are unrelated to this change. I ran against the current HEAD of master and it also hit 93 failures.
The current py36 failures are unrelated to this change. I ran against the current HEAD of master and it also hit 93 failures.
yeah, I wonder if we should drop py36 at this point, zaza is running on focal (py38) when consumed by zosci, and I don't expect developers to be running on bionic (py36) since it went EOL already. //cc @ajkavanagh
These should be exercising this code: https://review.opendev.org/q/topic:dnm-2023-2088
I've put this review up to drop py36, py37 and py39: https://github.com/openstack-charmers/zaza/pull/603
The most recent update should have full unit test coverage.
Good catch, looking. I hadn't scrolled down to those failures.
This is a WIP, just looking to get some input before writing tests.