openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
11 stars 47 forks source link

Add overlay_ppa to tests_options #602

Closed coreycb closed 1 year ago

coreycb commented 1 year ago

This is a WIP, just looking to get some input before writing tests.

freyes commented 1 year ago

I didn't think there would be a use case to use more than one PPA but it might not hurt to code it that way from the start. yeah, I'm thinking on the edge cases where you want to stack a ppa from your personal namespace with the security proposed ppa, because you are testing a bug or something.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 :tada:

Comparison is base (b2f2b46) 89.17% compared to head (986474b) 89.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #602 +/- ## ========================================== + Coverage 89.17% 89.22% +0.05% ========================================== Files 44 44 Lines 4655 4677 +22 ========================================== + Hits 4151 4173 +22 Misses 504 504 ``` | [Impacted Files](https://app.codecov.io/gh/openstack-charmers/zaza/pull/602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers) | Coverage Δ | | |---|---|---| | [zaza/utilities/deployment\_env.py](https://app.codecov.io/gh/openstack-charmers/zaza/pull/602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openstack-charmers#diff-emF6YS91dGlsaXRpZXMvZGVwbG95bWVudF9lbnYucHk=) | `99.10% <100.00%> (+0.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

coreycb commented 1 year ago

The current py36 failures are unrelated to this change. I ran against the current HEAD of master and it also hit 93 failures.

freyes commented 1 year ago

The current py36 failures are unrelated to this change. I ran against the current HEAD of master and it also hit 93 failures.

yeah, I wonder if we should drop py36 at this point, zaza is running on focal (py38) when consumed by zosci, and I don't expect developers to be running on bionic (py36) since it went EOL already. //cc @ajkavanagh

coreycb commented 1 year ago

These should be exercising this code: https://review.opendev.org/q/topic:dnm-2023-2088

coreycb commented 1 year ago

I've put this review up to drop py36, py37 and py39: https://github.com/openstack-charmers/zaza/pull/603

coreycb commented 1 year ago

The most recent update should have full unit test coverage.

coreycb commented 1 year ago

Good catch, looking. I hadn't scrolled down to those failures.