Fix Code becoming integer.

openstack-charmers / zaza

A Python3-only functional test framework for Charms

Apache License 2.0

10 stars 46 forks source link

Fix Code becoming integer. #617

Closed jneo8 closed 11 months ago

jneo8 commented 11 months ago

Value of the Code key in the returned Dict is str in master branch. However while trying to get compatible with juju 3.x series it became int. Now it is not conforming to the function signature. Also there are usages in some tests so it reverted back to str.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files	Coverage Δ
zaza/model.py	`87.31% <100.00%> (ø)`

:loudspeaker: Thoughts on this report? Let us know!.

ajkavanagh commented 11 months ago

The failure is not related to the change, and this will be a short lived branch. Merging on that basis.