search

openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
10 stars 46 forks source link

Avoid broken macaroonbakery release #623

Closed lathiat closed 9 months ago

lathiat commented 9 months ago

macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement to avoid that specific release: https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94

As seen here: https://openstack-ci-reports.ubuntu.com/artifacts/934/902745/1/check/focal-ussuri-ha-ovn/9344a64/job-output.txt

coreycb commented 9 months ago

Thanks Trent!

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff396eb) 89.43% compared to head (8be4948) 89.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #623 +/- ## ======================================= Coverage 89.43% 89.43% ======================================= Files 44 44 Lines 4693 4693 ======================================= Hits 4197 4197 Misses 496 496 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coreycb commented 9 months ago

LGTM but I can't merge it.