openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
10 stars 46 forks source link

Avoid broken macaroonbakery release #632

Closed javacruft closed 8 months ago

javacruft commented 8 months ago

macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement to avoid that specific release: https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94

(cherry picked from commit 8be49486c880b99c40253520dfcf110d5bf89c88)

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e3b91b) 89.14% compared to head (12ff9e7) 89.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## libjuju-3.1 #632 +/- ## ============================================ Coverage 89.14% 89.14% ============================================ Files 44 44 Lines 4689 4689 ============================================ Hits 4180 4180 Misses 509 509 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ajkavanagh commented 8 months ago

This looks like it broke due to breaking changes between Juju 2.9 -> 3.1:

Model       Cloud/Region         Type  Status     Machines  Units  Access  Last connection
controller  localhost/localhost  lxd   available         1      1  admin   just now
++ juju models --format yaml
++ grep '^- name:.*zaza'
++ cut -f2 -d/
+ model=
+ juju status -m
+ tee logs/juju-status.txt
ERROR option needs an argument: -m
+ juju crashdump -m -o logs/
ERROR juju: "crashdump" is not a juju command. See "juju --help".

Is it important for this branch to fix it, or would you just like it merged for convenience?

javacruft commented 8 months ago

@ajkavanagh I really need to unblock our charm testing gate - I'm running this cherry-pick through with https://review.opendev.org/c/openstack/sunbeam-charms/+/903563 to check it works OK

ajkavanagh commented 8 months ago

@ajkavanagh I really need to unblock our charm testing gate - I'm running this cherry-pick through with https://review.opendev.org/c/openstack/sunbeam-charms/+/903563 to check it works OK

Right, that seems reasonable. Once that passes, we can merge.

javacruft commented 8 months ago

@ajkavanagh review passed testing :+1:

ajkavanagh commented 8 months ago

@ajkavanagh review passed testing 👍

Oh yes! It all runs upstream; I was mistakenly looking for zOSCI. Merging now.