Closed javacruft closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6e3b91b
) 89.14% compared to head (12ff9e7
) 89.14%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks like it broke due to breaking changes between Juju 2.9 -> 3.1:
Model Cloud/Region Type Status Machines Units Access Last connection
controller localhost/localhost lxd available 1 1 admin just now
++ juju models --format yaml
++ grep '^- name:.*zaza'
++ cut -f2 -d/
+ model=
+ juju status -m
+ tee logs/juju-status.txt
ERROR option needs an argument: -m
+ juju crashdump -m -o logs/
ERROR juju: "crashdump" is not a juju command. See "juju --help".
Is it important for this branch to fix it, or would you just like it merged for convenience?
@ajkavanagh I really need to unblock our charm testing gate - I'm running this cherry-pick through with https://review.opendev.org/c/openstack/sunbeam-charms/+/903563 to check it works OK
@ajkavanagh I really need to unblock our charm testing gate - I'm running this cherry-pick through with https://review.opendev.org/c/openstack/sunbeam-charms/+/903563 to check it works OK
Right, that seems reasonable. Once that passes, we can merge.
@ajkavanagh review passed testing :+1:
@ajkavanagh review passed testing 👍
Oh yes! It all runs upstream; I was mistakenly looking for zOSCI. Merging now.
macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement to avoid that specific release: https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
(cherry picked from commit 8be49486c880b99c40253520dfcf110d5bf89c88)