search

openstack-charmers / zaza

A Python3-only functional test framework for Charms
Apache License 2.0
10 stars 46 forks source link

Only wait if an object is awaitable. #650

Closed wolsen closed 6 months ago

wolsen commented 6 months ago

Between juju 2.x and 3.x, the resulting return objects from the run method has changed to be awaitable or not. This change checks to see if the resulting object can be awaited or not. Without this, zaza will simply hang waiting on the results of an object which is not actually awaitable.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.54%. Comparing base (c44d359) to head (a3e18a9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #650 +/- ## ========================================== + Coverage 89.50% 89.54% +0.03% ========================================== Files 45 45 Lines 4744 4762 +18 ========================================== + Hits 4246 4264 +18 Misses 498 498 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wolsen commented 6 months ago

Note this PR is exercised in https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/909617

wolsen commented 6 months ago

Also being exercised for sunbeam charms at https://review.opendev.org/c/openstack/sunbeam-charms/+/910872