openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

Add BarbicanSpecCore struct #105

Closed dprince closed 7 months ago

dprince commented 7 months ago

This version of the struct (called "core") is meant to be used via the OpenStackControlplane. It is the same as BarbicanSpec only it is missing the containerImages from the nested API, Backup, Scheduler, and Volume specs.

The Default() function for webhooks has been split accordingly.

Jira: OSPRH-4835

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vakwetu commented 7 months ago

/lgtm