search

openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

migrate from databaseUsername to databaseAccount and fully use MariaDBAccount #107

Closed zzzeek closed 7 months ago

zzzeek commented 7 months ago

…BAccountLead Jira: OSPRH-4095

  1. [x] controller calls EnsureMariaDBAccount up front to make sure MariaDBAccount is present
  2. [x] error code from EnsureMariaDBAccount is handled, Conditions are amended when error is returned
  3. [x] controller calls NewDatabaseForAccount instead of NewDatabase
  4. [x] GetAccountAndSecret is used to retrieve account /secret to populate template
  5. [x] GetDatabaseByName() , normally used for delete finalizers, replaced with GetDatabaseByNameAndAccount
  6. [x] CreateOrPatchAll() used to patch the Database, replacing CreateOrPatchDB / CreateOrPatchDBByName
  7. [x] controller calls DeleteUnusedMariaDBAccountFinalizers when launched pods are definitely running on a new MariaDBAccount, returns error code if present
  8. [x] PasswordSelectors that refer to database are removed
  9. [x] all databaseUser replaced with databaseAccount inside of all XYZ_types.go
  10. [x] all databaseUser replaced with databaseAccount inside of all kuttl/*.yaml
  11. [x] all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all XYZ_types.go
  12. [x] all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all kuttl/*.yaml
  13. [x] MariaDBAccountSuiteTests are used in controller ginkgo tests if it has them
  14. [x] 184 is merged and replaces from go.mod are removed
zzzeek commented 7 months ago

this one should be all set cc @stuggi

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi, zzzeek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment