search

openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

Pin setup-envtest at working commit to fix functional tests #109

Closed raukadah closed 6 months ago

raukadah commented 6 months ago

https://github.com/kubernetes-sigs/controller-runtime/pull/2693 broke the functional tests running downstream with following issue[1]

In order to unblock the CI, we are pinning sigs.k8s.io/controller-runtime/tools/setup-envtest at previous working commit[2]

Links: [1]. https://github.com/kubernetes-sigs/controller-runtime/issues/2720 [2]. https://github.com/kubernetes-sigs/controller-runtime/commit/c7e1dc9b5302d649d5531e19168dd7ea0013736d

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [abays] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment