search

openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

Check for valid service override endpoint type on create and update #115

Closed stuggi closed 4 months ago

stuggi commented 5 months ago

Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/505

stuggi commented 5 months ago

/hold until after freeze

stuggi commented 5 months ago

It looks like the ValidateRoutedOverrides function is missing.

its because the kuttl job can not resolve the replace in the go.mod correct to build the operator. when we land lib-common, the job should be ok.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi, xek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [stuggi,xek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment