search

openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

Adding nodeSelector functionality #153

Closed mauricioharley closed 1 month ago

mauricioharley commented 1 month ago

The previous Barbican operator's code was not taking actions when the nodeSelector attribute was specified in the control plane. This patch addresses the missing part.

mauricioharley commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, mauricioharley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [abays,mauricioharley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mauricioharley commented 1 month ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 1 month ago

@mauricioharley: new pull request created: #154

In response to [this](https://github.com/openstack-k8s-operators/barbican-operator/pull/153#issuecomment-2302397839): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.