search

openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

[sample] comment optional nodeSelector #159

Closed stuggi closed 1 month ago

stuggi commented 1 month ago

When other services deploy barbican as a dependency in CI using the barbican sample the nodeselector functionality, which was added recently with https://github.com/openstack-k8s-operators/barbican-operator/pull/153 prevents the pods from being able to be scheduled. Therefore this change will comment these optional settings.

stuggi commented 1 month ago

seen in https://github.com/openstack-k8s-operators/swift-operator/pull/267#issuecomment-2337244379

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [abays,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cschwede commented 1 month ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 1 month ago

@cschwede: new pull request created: #160

In response to [this](https://github.com/openstack-k8s-operators/barbican-operator/pull/159#issuecomment-2345605723): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.