search

openstack-k8s-operators / barbican-operator

Apache License 2.0
5 stars 24 forks source link

Continuation pr145 #164

Closed mauricioharley closed 2 weeks ago

mauricioharley commented 2 weeks ago

This PR is a continuation of PR #145. Barbican Keystone Listener and Barbican Worker were missed being fixed.

abays commented 2 weeks ago

It looks like this PR wasn't rebased properly, given all the extra commits. Let me see if it can be cleaned up.

abays commented 2 weeks ago

@mauricioharley I think I've cleaned up the commits. Please look at the code changes to make sure I didn't undo anything.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, mauricioharley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/barbican-operator/blob/main/OWNERS)~~ [abays,mauricioharley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment