Closed bshephar closed 8 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bshephar Once this PR has been reviewed and has the lgtm label, please assign xek for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@bshephar: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/barbican-operator-build-deploy-kuttl | 3e175c3b469c745fe84243afc46ce1161e41edf0 | link | true | /test barbican-operator-build-deploy-kuttl |
ci/prow/precommit-check | cfac7a4abb3da598d141ba1c41dbffcce3804fc9 | link | true | /test precommit-check |
Full PR test history. Your PR dashboard.
This changes updates the controller-runtime and fixes the initialisation of objects to comply with the new controller-runtime standards. Namely:
We fix the function signatures of the webhook to include admissions.Warnings: https://github.com/kubernetes-sigs/controller-runtime/commit/8770b4d3b5425b156f48c971ee140ea25f9c1bfa
We fix the initialisation of the manager to declare the webhook following the new schema: https://github.com/kubernetes-sigs/controller-runtime/commit/91cdd8c9539c4860c5bacad36ebf75e4271f726d
We fix the Watches function to comply with the new signature definition: https://github.com/kubernetes-sigs/controller-runtime/commit/dc62ed5dadc6ea2d3e22546368b939a2db1edfb2
Add context to EventHandlers: https://github.com/kubernetes-sigs/controller-runtime/commit/2464a9d7af4911c6bf6e0baaaf8dc0ab08c7452c