use the datasources field for the nova dataplane service def

[SeanMooney]

This change ports the nova OpenstackDataplaneService to use the recently added datasources field.

This allows the default dataplane service to optionally support constom service config via a config called nova-extra-config

This name was choosen to aling to the default custom service config used in the ci framework.

Related: OSPRH-6407

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SeanMooney Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[SeanMooney]

looks like i need to update one of the env tests but ill leave the rest run to completion before i rebase

[SeanMooney]

actully that passed locally... so ill retrigger that job. i guess its a flaky test.

[SeanMooney]

/test functional

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b88aba456a2149d6aa43d4cb7d46b6f7

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 20m 39s :x: podified-multinode-edpm-deployment-crc RETRY_LIMIT in 18m 02s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 29m 13s

[fao89]

/retest-required

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1f7f2a4ce6264f9a8ad6df0d524d2c87

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 42m 32s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 30s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 29m 43s

[slagle]

I switched the json field name to be dataSources, so this will need an update

[slagle]

I switched the json field name to be dataSources, so this will need an update

I updated it, hope you don't mind

[slagle]

/retest

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/453612be3ddb4a9385c5f212a848df80

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 05m 58s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 48s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 30m 51s

[fao89]

/retest-required

[fao89]

recheck

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5be4e6b3dd6a4f15865d25e5d1c7f92d

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 4h 37m 39s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 36s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 38m 41s

[SeanMooney]

check-rdo

[SeanMooney]

/retest-required

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7cb40a1962a248a2a4b9b428ff5c155a

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 06m 06s :x: podified-multinode-edpm-deployment-crc FAILURE in 36m 21s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 42m 05s

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/31ef6e4b669c4d928c5cb10fc3245c63

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 00m 43s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 37m 48s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 35m 29s

[fao89]

As I added this change to https://github.com/openstack-k8s-operators/openstack-operator/pull/765 I found an issue with the dataSources code, the yaml isn't correctly parsed, I had to add the yaml notation to fix it: https://github.com/fao89/openstack-operator/blob/mergedataplane/apis/dataplane/v1beta1/common.go#L35-L74

[openshift-ci[bot]]

@SeanMooney: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/dataplane-operator-build-deploy-kuttl	b0c3e43395fd5f48c8649bff6785264d38d910d9	link	true	/test dataplane-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5e17d2e52e89426bb88fdc8eec7e975b

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 58m 45s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 36m 07s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 28m 17s