openstack-k8s-operators / dataplane-operator

Operator for OpenStack Dataplane
https://openstack-k8s-operators.github.io/dataplane-operator/
Apache License 2.0
3 stars 47 forks source link

Set RoleRef.APIGroup to fix reconcile loop #921

Closed slagle closed 5 months ago

slagle commented 5 months ago

Set RoleRef.APIGroup to fix reconcile loop

Without setting RoleRef.APIGroup, we keep updating RoleBinding since APIGroup will be set automatically, and dataplane-operator will unset it. Setting it explicitly fixes that loop.

Jira: https://issues.redhat.com/browse/OSPRH-7543 Signed-off-by: James Slagle jslagle@redhat.com

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/OWNERS)~~ [slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 5 months ago

/retest

could not run steps: step ansibleee-operator-build-deploy-kuttl failed: failed to wait for the created cluster claim to become ready: timed out waiting for the condition