search

openstack-k8s-operators / dev-docs

Documentation
9 stars 25 forks source link

[test-strategy]Add lib-common specific rules #32

Closed gibizer closed 1 year ago

gibizer commented 1 year ago

This is based on the comments from @stuggi in https://github.com/openstack-k8s-operators/docs/pull/20

gibizer commented 1 year ago

I've added @fmount from storage and @slagle from edpm side as this affects the storage and ansible modules of lib-common too.

slagle commented 1 year ago

+2 from me. We already have some initial unit test coverage in https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/ansible/inventory_test.go for the ansible related functionality.

gibizer commented 1 year ago

+2 from me. We already have some initial unit test coverage in https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/ansible/inventory_test.go for the ansible related functionality.

Thanks. As far as I see the ansible module also does not reach out to k8s APIs so the existing unit test coverage is good as is and I will assume the same for the incoming new features for now as well.