search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Add become: True to node_exporter when TLS enabled #611

Closed vyzigold closed 5 months ago

vyzigold commented 5 months ago

Node Exporter fails to start and then the service fails with:

TASK [osp.edpm.edpm_telemetry : Restart node_exporter] *************************
task path: /usr/share/ansible/collections/ansible_collections/osp/edpm/roles/edpm_telemetry/tasks/install.yml:139
fatal: [compute-0]: FAILED! => {"changed": false, "msg": "Unable to restart service edpm_node_exporter.service: Job for edpm_node_exporter.service failed because the control process exited with error code.\nSee \"systemctl status edpm_node_exporter.service\" and \"journalctl -xeu edpm_node_exporter.service\" for details.\n"}

We're already using "become: true" in the non-tls version of the task.

We have another PR blocked by this issue: https://github.com/openstack-k8s-operators/dataplane-operator/pull/754

jlarriba commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, vyzigold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [fao89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment