search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

[edpm_nova]Do not add immutable flag to compute_id #619

Closed gibizer closed 5 months ago

gibizer commented 5 months ago

The podman version 4.6.0 has a bug that causes that sometimes a container fails to start if it mounts an file with +i flag set. This podman version is used in the adoption form state making the adoption unstable (1 in 8 CI run fails). The greenfield 18 deployment uses podman 4.9.4 that does not show this error. So to make the adoption stable the edpm_nova role will not add the +i flag to existing compute_id files. Still if the role pre-generates the file that means it is a greenfield run so the flag can be, and will be, set safely.

gibizer commented 5 months ago

/hold

softwarefactory-project-zuul[bot] commented 5 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/441989fd407446bc8607cf311ac3b60c

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 01m 40s :x: podified-multinode-edpm-deployment-crc RETRY_LIMIT in 28m 40s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 43m 54s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 5m 41s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 4m 52s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 3m 58s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 06s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 12s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 13s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 49s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 55s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 32s

gibizer commented 5 months ago

/unhold https://github.com/openstack-k8s-operators/data-plane-adoption/pull/370 shows that we need to do this to stabilize adoption

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, fao89, gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [SeanMooney,fao89,gibizer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bogdando commented 5 months ago

At which point and where that flag will be set for greenfield?

gibizer commented 5 months ago

At which point and where that flag will be set for greenfield?

https://github.com/openstack-k8s-operators/edpm-ansible/pull/619/files#diff-36ab95b79773d7839c0045b3afd39c2c9acdf90e31693d9a61afc50af8f6ade2R165

gibizer commented 5 months ago

/retest-required

fao89 commented 5 months ago

it seems we got some hiccup with tide

gibizer commented 5 months ago

merging this manually as tide seems to be in bad state. all the relevant tests passed.