Check an FQDN is set

[slagle]

An FQDN should be set, and a validation is added to check. The validation can be disabled with the edpm_nodes_validation_check_for_fqdn variable.

Depends-On: https://github.com/openstack-k8s-operators/install_yamls/pull/797 Jira: https://issues.redhat.com/browse/OSPRH-6187 Signed-off-by: James Slagle jslagle@redhat.com

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@slagle: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/pre-commit-test	1eb998610021984a4ad099a8748baa0df1dffa7f	link	true	/test pre-commit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a3ce407f455e4be9a60c0ac75e56306d

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 19m 18s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 41m 36s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 2h 00m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 4m 48s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 28s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 8m 29s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 45s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 03s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 49s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 54s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 12s

[slagle]

/hold per ongoing discussion

[gibizer]

I think this overlaps with #609 ? @gibi WDYT?

I think 609 is more adoption focused and it mainly there to ensure that the hostname the edpm openstack service are configured with are not changing during adoption. This PR cannot ensure that.

[bogdando]

we don't need different checks for greenfield vs adoption. please redesign the inputs requirements for osdpns instead. Make explicit hostnames required for each edpm host in each osdpns ansible vars. Make a single check to fail a deployment, when that intput doesn't match a discovered hostname -f of a edpm node

In case of baremetal provisioned nodes, those hostnames inputs may come automatically, by webhooks, or the BM controller itself, based on its "introspected inventory" data outputs

[slagle]

we don't need different checks for greenfield vs adoption. please redesign the inputs requirements for osdpns instead. Make explicit hostnames required for each edpm host in each osdpns ansible vars. Make a single check to fail a deployment, when that intput doesn't match a discovered hostname -f of a edpm node

In case of baremetal provisioned nodes, those hostnames inputs may come automatically, by webhooks, or the BM controller itself, based on its "introspected inventory" data outputs

I don't think that would solve anything since canonical_hostname is what is used in various service configs.