openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Fix roles default vars to correctly use edpm_service_name #643

Closed karelyatin closed 4 months ago

karelyatin commented 4 months ago

Some vars were not using "edpm_service_name" for the generated content, this patch fixes it.

Additionally fixed some unused vars.

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f740d5b512de465898c40fc04b3e06e5

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 04m 11s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 41m 49s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 42m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 24s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 25s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 19s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 33s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 12s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 49s :x: edpm-ansible-molecule-edpm_frr FAILURE in 5m 55s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 23s :x: edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 7m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 39s

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [jpodivin,karelyatin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment