openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

When kernelargs are changed, ensure reboot file exists #648

Closed bshephar closed 6 months ago

bshephar commented 6 months ago

When kernelargs are changed, ensure reboot file exists

This change ensures that the edpm_kernel file is created under the reboot_required directory when grub.cfg has been updated. This ensures the user is able to determine when a node needs rebooting[1], and they can do so by including our edpm_reboot role via the reboot.yml playbook in a servicesOverride on the deployment.

[1] https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/docs/source/roles/role-edpm_reboot.rst?plain=1#L10-L18

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [bshephar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment