openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Allow ovn-encap-tos to be configured #652

Closed umago closed 3 months ago

umago commented 4 months ago

This patch allows for the ovn-encap-tos to be configured in ovn-controller.

By default this option has the value of 0, as per OVS options:tos description [0], but it could also contain the word "inherit" therefore the field type for this patch is "str".

[0] options : tos: optional string Optional. The value of the ToS bits to be set on the encapsulat‐ ing packet. ToS is interpreted as DSCP and ECN bits, ECN part must be zero. It may also be the word inherit, in which case the ToS will be copied from the inner packet if it is IPv4 or IPv6 (otherwise it will be 0). The ECN fields are always inherited. Default is 0.

http://www.openvswitch.org/support/dist-docs/ovs-vswitchd.conf.db.5.txt

Resolves: OSPRH-6712

booxter commented 4 months ago

/lgtm

karelyatin commented 4 months ago

/lgtm

It's required for Beta automation blocker, so should be fine to get in.

I originally thought it would require changes in both ovn-operator and here to configure tunnel interfaces on both control plane and data plane. But seems configuring it here automatically get applies everywhere.

karelyatin commented 4 months ago

/hold

/lgtm

It's required for Beta automation blocker, so should be fine to get in.

I mistook it as Beta automation blocker, while the parent Epic was targetted for GA, so we can target it after beta freeze

booxter commented 4 months ago

/hold cancel

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[roles/edpm_ovn/OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_ovn/OWNERS)~~ [karelyatin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment