search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Add output of os-net-config file before applying in edpm_network_config #656

Closed marios closed 4 months ago

marios commented 4 months ago

Adds a debug task to display the contents of the os-net-config config file before this is applied. This can be especially useful if node connectivity is disrupted after the config is applied.

https://issues.redhat.com/browse/OSPRH-5754

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

frenzyfriday commented 4 months ago

/lgtm

pablintino commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny, marios, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [lewisdenny] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lewisdenny commented 4 months ago

Approving due to multiple lgtm and basic change.