openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Use correct standalone container name for DHCP agent #657

Closed cubeek closed 4 months ago

cubeek commented 4 months ago

The Neutron DHCP agent doesn't follow naming convention for Neutron agent services in standalone. It does not contain the _agent suffix and is named just neutron_dhcp.

Resolves: OSPRH-6703

openshift-ci[bot] commented 4 months ago

Hi @cubeek. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
booxter commented 4 months ago

/ok-to-test

booxter commented 4 months ago

/lgtm

booxter commented 4 months ago

/hold

waiting for Beta release to merge

fao89 commented 4 months ago

/unhold

fao89 commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cubeek, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[roles/edpm_neutron_dhcp/OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_neutron_dhcp/OWNERS)~~ [fao89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment