search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Drop usage of edpm_service_name #658

Closed slagle closed 4 months ago

slagle commented 4 months ago

edpm_service_name corresponds to the DataPlaneService name, creating tight coupling between the name of the service and the expected podman volume paths.

This breaks many assumptions around custom DataPlaneServices, and the fact that different services may use the same ansible roles, or a single service may use multiple ansible roles that need different volume paths.

These paths should instead be isolated from the DataPlaneService name. This commit drops usage of edpm_service_name which is set by dataplane-operator, and adds a new var per role for creating the path. The new vars will not be set by dataplane-operator.

A corresponding dataplane-operator commit will take care of creating the paths so that they are in the ansible role expected locations.

Jira: https://issues.redhat.com/browse/OSPRH-7112 Signed-off-by: James Slagle jslagle@redhat.com

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/09c04585bcf34b0aa2488fb189fde348

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 09m 00s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 51s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 51m 03s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 19s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 54s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 45s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 42s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 29s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 20s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 52s

slagle commented 4 months ago

/hold

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [fao89,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 4 months ago

/unhold