openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Stop overwriting EFI grub.cfg #659

Closed steveb closed 3 months ago

steveb commented 3 months ago

The EFI grub.cfg is being replaced with a RHEL style redirect[1] so that it no longer has to be updated along with the /boot/grub2/grub.cfg. This change removes the tasks which overwrite the EFI grub.cfg, which undoes the fix in [1].

An equivalent change is occuring for 17.1 images[2] and for upgrade paths into 17.1[3] so we will be able to ensure any host upgrading to 18.0 will have the correct redirect grub.cfg in place.

[1] https://github.com/openstack-k8s-operators/edpm-image-builder/pull/30 [2] https://code.engineering.redhat.com/gerrit/c/openstack-tripleo-image-elements/+/452100 [3] https://code.engineering.redhat.com/gerrit/c/tripleo-ansible/+/452086 https://code.engineering.redhat.com/gerrit/c/openstack-tripleo-heat-templates/+/452099

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fb421740fb524b37bd949853f1de79a7

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 34m 00s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 14m 55s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 43m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 33s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 5m 24s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 35s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 8m 33s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 8m 47s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 6m 30s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 59s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 13s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 56s

juliakreger commented 3 months ago

recheck failure appears to be with registering the subscription with openshift.

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3db8e4edd962465f8bbd9a6b4802f955

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 30m 38s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 14m 10s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 45m 24s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 28s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 5m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 37s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 9m 30s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 13s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 9m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 6m 25s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 45s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 01s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 17s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 06s

steveb commented 3 months ago

recheck

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8c989fe9f41b4784bc99a6d99be583b2

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 25m 06s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 09m 17s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 2h 01m 50s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 12s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 23s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 44s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 51s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 58s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 31s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 13s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 59s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 28s

steveb commented 3 months ago

recheck

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, jpodivin, steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment