openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Add ovs update into edpm_ovs role #665

Closed mtomaska closed 2 months ago

mtomaska commented 3 months ago

Openvswitch(ovs) update requires special attention in respect to the rest of the update on a edpm_node.

The OVS update must not stop and/or restart ovs services in order not to disturb the dataplane networking. If "restart" is required, it must be done via the systemctl reload option, which would trigger OVS builtin mechanism that allows reloading OVS services without disturbing already present Openflows on the edpm node. By default , we do not reload on update but the edpm_ovs_reload_after_update can be overwritten to reload if desired.

NOTE about molecule testing: This PR contains the first multi-scenario non-containerized test. Up to now, non-containerized tests contained a single default scenario which was run as a separate Zuul job. Currently, the ci-framework does not support running multi-scenario molecule tests. There is work is captured in JIRA-7812 to support it. As a stopgap, this PR includes cleanup.yml playbook which should cleanup the test instance between each scenario run.

JIRA: OSPRH-6141

openshift-ci[bot] commented 3 months ago

Hi @mtomaska. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e9ae4e59d0ff46eab7ba57dd00be1a7b

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 55m 05s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 14m 00s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 44m 48s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 5m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 40s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 9m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 31s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 8m 48s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 6m 24s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 37s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 10s

booxter commented 3 months ago

/ok-to-test

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cc9d3c14aed146a89acbde7b47c35400

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 25m 10s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 08m 12s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 2h 07m 31s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 18s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 02s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 47s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 19s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 19s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 01s :x: edpm-ansible-molecule-edpm_ovs FAILURE in 6m 14s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 22s

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/49bab805b2e84946ae10936266bc95ca

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 09m 24s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 41m 43s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 53m 37s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 8m 13s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 17s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 52s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 11m 12s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 11m 29s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 36s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 02s :x: edpm-ansible-molecule-edpm_ovs FAILURE in 6m 20s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 47s

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/24db6c3f982a4828af8e968780f05e25

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 10m 04s :x: podified-multinode-edpm-deployment-crc RETRY_LIMIT in 9m 50s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 54m 17s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 35s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 33s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 49s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 37s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 15s :x: edpm-ansible-molecule-edpm_ovs FAILURE in 6m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 43s

booxter commented 3 months ago

This is being investigated in: https://github.com/openstack-k8s-operators/edpm-ansible/pull/679

booxter commented 3 months ago

/lgtm

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/25aee12a47784f719910a5560c34fb15

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 11m 28s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 52m 08s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 55m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 21s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 28s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 16s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 11m 23s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 57s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 38s :x: edpm-ansible-molecule-edpm_ovs FAILURE in 8m 23s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 42s

booxter commented 2 months ago

/lgtm

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/48d89ed3b6554f96b794dec7c1f821e0

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 00m 01s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 46m 22s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 21m 33s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 39s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 5m 17s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 44s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 9m 50s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 8m 56s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 6m 41s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 41s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 15m 38s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 53s

mtomaska commented 2 months ago

recheck

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/56ddb06cec7f4cf88cf8949368d8b8a9

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 12m 53s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 40s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 57m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 29s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 47s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 45s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 30s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 26s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 13m 06s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 47s

booxter commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, mtomaska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [karelyatin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment