search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Fix file ownership for neutron dhcp and metadata agent #670

Closed mtomaska closed 3 months ago

mtomaska commented 3 months ago

Installation tasks in the edpm_neutron_dhcp and edpm_neutron_metadata were using default(lookup('pipe', 'whoami')) which by design runs on the ansible controller and not the target host as this tasks intends. Replacing with default(ansible_user_id) which is the user that Ansible logs in.

JIRA: OSPRH-7321

openshift-ci[bot] commented 3 months ago

Hi @mtomaska. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mtomaska commented 3 months ago

/ok-to-test

openshift-ci[bot] commented 3 months ago

@mtomaska: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/670#issuecomment-2159615420): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rabi commented 3 months ago

@mtomaska: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

You can request the admins in slack to add you to openstack-k8s-operators group. @abays can help.

rabi commented 3 months ago

/ok-to-test

booxter commented 3 months ago

/lgtm

booxter commented 3 months ago 
      "msg": "The task includes an option with an undefined variable. The error was: 'ansible_user' is undefined. 'ansible_user' is undefined\n\nThe error appears to be in '/home/runner/.cache/ansible-compat/498985/collections/ansible_collections/osp/edpm/roles/edpm_neutron_metadata/tasks/install.yml': line 17, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create persistent directories\n  ^ here\n"
booxter commented 3 months ago

/lgtm

booxter commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, mtomaska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[roles/edpm_neutron_dhcp/OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_neutron_dhcp/OWNERS)~~ [booxter] - ~~[roles/edpm_neutron_metadata/OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_neutron_metadata/OWNERS)~~ [booxter] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1ce7bb965ec1421d95653f1657cf3356

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 4h 06m 29s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 50m 04s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 01m 39s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 23s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 5m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 45s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 05s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 19s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 8m 58s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 6m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 5m 09s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 00s :x: cifmw-data-plane-adoption-osp-17-to-extracted-crc TIMED_OUT in 3h 14m 01s

booxter commented 3 months ago

recheck

    timed out waiting for the condition on pods/community-operators-5f87q
    timed out waiting for the condition on pods/community-operators-7b584
    timed out waiting for the condition on pods/marketplace-operator-69d564865b-cfpkp
    timed out waiting for the condition on pods/redhat-marketplace-wkb7c
    timed out waiting for the condition on pods/redhat-operators-4gdrm
karelyatin commented 3 months ago

/lgtm

Thanks let's ensure the changes are picked by ansibleee operator and openstack-operator for release before closing the linked Jira