openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

FIPS task should not change reboot policy #672

Closed vakwetu closed 5 months ago

vakwetu commented 5 months ago

As reported in https://issues.redhat.com/browse/OSPRH-7301 , the fips task incorrectly changes the reboot policy when the required fips status changes. We should follow whatever is defined by the deployer instead.

If nothing is defined, the policy is auto - which will result in a reboot.

In the case of a redeployed or adopted environment, we will end up simply logging that a reboot is supposed to happen. But we will then likely fail the subsquent fips status check - which is the desired behavior.

Resolves: https://issues.redhat.com/browse/OSPRH-7301

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor, vakwetu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [rebtoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment