search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Fix dport and port iteration #674

Closed bshephar closed 5 months ago

bshephar commented 5 months ago

The current implementation just checks that the port provided by the user is iterable. This results in a value such as:

dport: 1234-5678

Being iterated over and trying to apply "1,2,3,4,-,5,6,7,8" which is obviously not desireable. This change adds more strict checking to the value to ensure we only try to iterate over lists.

Resolves: rhbz#2276865

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [bshephar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cjeanner commented 5 months ago

/lgtm

cjeanner commented 5 months ago

/lgtm

since anything can be iterable in python... Fun it didn't break before though.