search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

Disable martian packts logging as default #684

Closed eshulman2 closed 2 months ago

eshulman2 commented 2 months ago

Logging martian packets is done via printk. Depending on the default console configuration, it may cause writing on a serial line. Some UART controllers are slow, and it may stall CPUs for up to 200ms. When this logging happens, it causes random latency issues.

Disable logging of martian packets by default. It can be enabled for debugging purposes.

eshulman2 commented 2 months ago

CC @rjarry

openshift-ci[bot] commented 2 months ago

@rjarry: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/684#pullrequestreview-2141518941): >Hi @eshulman2 thanks for the patch. This looks good to me. Logging to the console causes so many issues, it is best to avoid that at all costs. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eshulman2, rjarry, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment