openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Disable firewalld service in `edpm_nftables` role #687

Closed rebtoor closed 4 months ago

rebtoor commented 4 months ago

Since we are defining firewall rules with edpm_nftables role (using nftables service), it's useless and potentially harmful keep firewalld enabled and running on the host.

Fixes: https://issues.redhat.com/browse/OSPRH-7739

Signed-off-by: Roberto Alfieri ralfieri@redhat.com

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [bshephar,rebtoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment