search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Use edpm_service_types in edpm_update #702

Closed slagle closed 3 months ago

slagle commented 3 months ago

The list of service types is added as an ansible variable to the inventory as edpm_service_types. This will be used instead of edpm_services since service names could be any custom value.

edpm-ansible roles such as edpm_update, need a list of consistent service identifiers (types instead of names), so it knows which other roles to include for update tasks.

Depends-On: https://github.com/openstack-k8s-operators/openstack-operator/pull/962 Jira: https://issues.redhat.com/browse/OSPRH-8107 Signed-off-by: James Slagle jslagle@redhat.com

softwarefactory-project-zuul[bot] commented 3 months ago

This change depends on a change that failed to merge.

Change https://github.com/openstack-k8s-operators/openstack-operator/pull/962 is needed.

softwarefactory-project-zuul[bot] commented 3 months ago

This change depends on a change that failed to merge.

Change https://github.com/openstack-k8s-operators/openstack-operator/pull/962 is needed.

slagle commented 3 months ago

recheck

rebtoor commented 3 months ago

I'll re-add the lgtm when the other PR will be merged.

softwarefactory-project-zuul[bot] commented 3 months ago

This change depends on a change that failed to merge.

Change https://github.com/openstack-k8s-operators/openstack-operator/pull/962 is needed.

slagle commented 3 months ago

recheck

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rebtoor, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [jpodivin,rebtoor,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 3 months ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 3 months ago

@slagle: new pull request created: #703

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/702#issuecomment-2245277146): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.