openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Fix result check syntax #705

Closed rabi closed 3 months ago

rabi commented 3 months ago

Otherwise it fails with below in case the package is not available, i.e correct repos are not enabled.

ASK [osp.edpm.edpm_bootstrap : Deploy network-scripts required for deprecated network service] *** fatal: [edpm-compute-1]: FAILED! => {"msg": "The conditional check 'edpm_bootstrap_legacy_network_packages_result.rc == 0' failed. The error was: error while evaluating conditional (edpm_bootstrap_legacy_network_packages_result.rc == 0): 'dict object' has no attribute 'rc'. 'dict object' has no attribute 'rc'"}

jira: https://issues.redhat.com/browse/OSPRH-8911

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rabi, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [fao89,rabi,rebtoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rabi commented 3 months ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 3 months ago

@rabi: new pull request created: #709

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/705#issuecomment-2249285181): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.