search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Restoring virt-pki-validate check in molecule test #715

Closed jpodivin closed 3 months ago

jpodivin commented 3 months ago

Resolves: OSPCIX-393

Permissions for directories are now set according to new virt-pki-validate recommendations. Instead of checking return code of the tool, we are now matching on output. This is because even a single warning changes rc to 1.

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d48e4408a43a4c71914312f9930e3583

:heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 20s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 5m 57s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 03s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 31s :x: edpm-ansible-molecule-edpm_libvirt FAILURE in 7m 35s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 37s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 03s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 01s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 48s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 46s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 33s

openshift-ci[bot] commented 3 months ago

@kashyapc: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/715#pullrequestreview-2218559410): >Looks good to me, FWIW. At least from the PoV of implementing the recommendations of `virt-pki-validate`. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, kashyapc, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [SeanMooney,jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment