search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

fix users and permissions on ovn-bgp-agent tasks #719

Closed eduolivares closed 1 month ago

eduolivares commented 1 month ago

The following PR changed the permissions and ownership for directories created from many roles: https://github.com/openstack-k8s-operators/edpm-ansible/pull/683

This PR removes become: true from the task that creates ovn-bgp-agent configuration directories.

It also fixes the tasks running ovs-vsctl commands from the ovn-bgp-agent role: they should be executed as root.

https://issues.redhat.com/browse/OSPRH-9191

eduolivares commented 1 month ago

@jpodivin, can you please take a look at this PR? I have verified it on my BGP downstream environment. Thanks!

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eduolivares, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
eduolivares commented 1 week ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 1 week ago

@eduolivares: new pull request created: #748

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/719#issuecomment-2339812475): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.