openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

[WIP] Fail edpm_network_config when there are schema errors #720

Open vcandapp opened 1 month ago

vcandapp commented 1 month ago

Currently when there are schema errors in os-net-config, the logs are updated and no failure happens. Updating this behaviour so that user can fix errors and re-run role

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vcandapp Once this PR has been reviewed and has the lgtm label, please assign karelyatin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bea8f390d77f469bbd15aab2a9685112

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 46m 26s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 10m 00s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 2h 03m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 54s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 15s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 05s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 08s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 36s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 47s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 6m 00s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 25s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 11m 54s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 48s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 49m 22s

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/99d7332914a34eab8a3f960458b62e4b

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 06m 17s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 09m 40s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 2h 03m 18s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 33s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 47s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 11m 53s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 46s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 9m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 6m 53s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 9m 40s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 14m 52s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 6m 15s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 48m 24s

vcandapp commented 1 month ago

@karthiksundaravel / @Jaganathancse , updated this PR for better tracking. This PR will have fix only for the no-auto-default. Will created a new PR for "--exit-on-validation-error"

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/29eab19ff4b04edab2033286198dc0a0

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 16m 47s :x: podified-multinode-edpm-deployment-crc FAILURE in 2h 09m 08s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 2h 17m 59s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 01s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 47s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 18s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 17s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 36s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 42s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 37s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 51m 39s

openshift-ci[bot] commented 1 day ago

@vcandapp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pre-commit-test 0689cf7fb84008c8777b4eb558687bd3eeed9fac link true /test pre-commit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
softwarefactory-project-zuul[bot] commented 1 day ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca21c54505884f99aa6234b9bb43f29d

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 25m 21s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 41m 39s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 40m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 59s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 01s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 00s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 19s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 30s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 51s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 36s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 16s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 58s :heavy_check_mark: edpm-ansible-molecule-edpm_tuned SUCCESS in 5m 51s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 12m 45s