search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 65 forks source link

[edpm_kernel] Improved kernel args block conditions #740

Closed rebtoor closed 3 weeks ago

rebtoor commented 3 weeks ago

The conditions required to enter the kernel args configuration block have been refactored.

The regular expression that checks for the edpm_kernel_args variable value presence in the command line arguments has been rewritten to intercept the substrings of the same parameters.

Also, the molecule test for this particular scenario, kernelargs-update-substring has been rewritten to catch these kind of errors.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/18.0.0-proposed/OWNERS)~~ [jpodivin,rebtoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment