search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Change action for config with `restart` in container_manage to `created` #743

Closed cubeek closed 3 weeks ago

cubeek commented 2 months ago

Don't start container if restarted is set

If the container_manage is called with restart set, it means the systemd handles the restart. In such case, we do not want containers to be started because they will be started later by the systemd.

Resolves: OSPRH-9812

bogdando commented 2 months ago

/lgtm

cubeek commented 2 months ago

I'm going to remove the WIP tag as this seems to be good to go.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cubeek, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 2 months ago

/retest

rabi commented 3 weeks ago

The commit message would need a change and also there is a merge commit in the PR.

cubeek commented 3 weeks ago

The commit message would need a change and also there is a merge commit in the PR.

Not sure if you meant really the commit message or the text in the PR. I copied the message from the commit message to be the same.

rabi commented 3 weeks ago

/lgtm

softwarefactory-project-zuul[bot] commented 3 weeks ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f0fc96b47c444185a2d9f8895bbc2d26

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 31m 23s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 24s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 41m 36s :x: edpm-ansible-tempest-multinode FAILURE in 1h 48m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 5m 40s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 4m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 3m 57s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 7m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 7m 24s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 8m 32s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 6m 02s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 11m 24s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_tuned SUCCESS in 5m 56s :heavy_check_mark: edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 6m 11s

fao89 commented 3 weeks ago

recheck