search

openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Check for AnsibleUnicode or str for edpm_kernel_args #747

Closed slagle closed 2 months ago

slagle commented 2 months ago

The type of edpm_kernel_args could be a str, so both types need to be checked, otherwise the whole block is skipped.

Jira: OSPRH-10007 Signed-off-by: James Slagle jslagle@redhat.com

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b96e3e4daed342ea81d9158f64f720b9

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 32m 21s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 52s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 21m 45s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 9m 56s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 26s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 57s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 20s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 16s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 11m 52s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 9m 56s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 11m 11s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 21m 22s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 58s :heavy_check_mark: edpm-ansible-molecule-edpm_tuned SUCCESS in 11m 01s

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [bshephar,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 1 month ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 1 month ago

@slagle: new pull request created: #753

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/747#issuecomment-2361055968): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.