openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

Fix ansible roles to always mount the cacerts #749

Closed vakwetu closed 1 month ago

vakwetu commented 2 months ago

If cacerts are present, they should be mounted even if tls_enabled is not set as they could contain third party certs.

Fixes edpm_neutron_ovn, edpm_ovn, neutron_sriov, neutron_metadata, edpm_ovn_bgp_agent, edpm_neutron_dhcp, telemetry

Jira: https://issues.redhat.com//browse/OSPRH-9451

vakwetu commented 2 months ago

Note: still needs some work to account for cases where cacerts are not present. Testing in progress.

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e4338376ad4b4f9ab3ab5818f8533e39

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 4h 29m 25s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 21s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 31s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 5m 44s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 4m 43s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 49s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 55s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 49s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 34s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 12s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 36s :x: edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 7m 31s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 52s :heavy_check_mark: edpm-ansible-molecule-edpm_tuned SUCCESS in 5m 59s :x: adoption-standalone-to-crc-ceph-provider TIMED_OUT in 4h 16m 47s

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f399b0b592804070a53b5062b62c4d87

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 4h 30m 26s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 42m 22s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 40m 01s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 02s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 26s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 03s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 43s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 09s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 10s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 52s :x: edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 7m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 07s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 05s :heavy_check_mark: edpm-ansible-molecule-edpm_tuned SUCCESS in 5m 47s :x: adoption-standalone-to-crc-ceph-provider TIMED_OUT in 4h 16m 52s

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/65ac71761bb248ac9efd8ce71f6f5607

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 28m 36s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 35s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 39s :heavy_check_mark: edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 12s :heavy_check_mark: edpm-ansible-molecule-edpm_podman SUCCESS in 6m 03s :heavy_check_mark: edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 08s :heavy_check_mark: edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 06s :heavy_check_mark: edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 50s :heavy_check_mark: edpm-ansible-molecule-edpm_nova SUCCESS in 10m 27s :heavy_check_mark: edpm-ansible-molecule-edpm_frr SUCCESS in 7m 08s :heavy_check_mark: edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 09s :heavy_check_mark: edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 38s :heavy_check_mark: edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 04s :heavy_check_mark: edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 17s :heavy_check_mark: edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 04s :x: adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 45m 53s

vakwetu commented 1 month ago

recheck

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, vakwetu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS)~~ [jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vakwetu commented 1 month ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 1 month ago

@vakwetu: new pull request created: #754

In response to [this](https://github.com/openstack-k8s-operators/edpm-ansible/pull/749#issuecomment-2362059487): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
karelyatin commented 1 month ago

This broke update job[1][2][3], for instance cacert no longer mounted in ovn_metadata container since this PR. non update job works fine.

[1] https://issues.redhat.com/browse/OSPRH-10450 [2] https://issues.redhat.com/browse/OSPRH-10451 [3] https://redhat-internal.slack.com/archives/C046JULBVJ7/p1727784824976069?thread_ts=1727764072.861919&cid=C046JULBVJ7